owlburtoe/Shiftd
owlburtoe/Shiftd
0
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases 1 Packages 3 Wiki Activity Actions 2

feat(android): surface shift tags on schedule and dashboard #332

Merged
owlburtoe merged 1 commit from android-shift-tags into main 2026-06-08 10:44:51 -04:00
Conversation 0 Commits 1 Files changed 6 +23
owlburtoe commented 2026-06-08 10:33:11 -04:00
Owner
Copy link

Summary

Android counterpart to #330. Renders shift tags (call, hot, preceptor, …) at a glance on the staff member's own shift display so they can see what type of shift they're working. A shift with no tags is a regular shift (nothing rendered).

Tags were already deserialized into ShiftSummary.tags from the schedule-detail endpoint and were already rendered on coworker rows ("Working Today"). This PR closes the remaining gap: the staff member's own shifts on the Schedule screen and the Dashboard next-shift hero.

No backend dependency

Unlike web (whose dashboard reads /staff/:id/upcoming-assignments), the Android dashboard and schedule both source shifts from the schedule-detail endpoint, which already carries tags on every shift. So this is a self-contained, Android-only change off main — it does not depend on #330's backend change.

Changes

File Change
schedule/ScheduleCalendarModels.kt Add tags: List<ShiftTagSummary> to ScheduleAssignmentDisplayRow
schedule/ScheduleCalendarDeriver.kt Populate tags = shift.tags when building the own-shift row
schedule/ScheduleScreen.kt Render tag pills (reusing existing RolePill) on AssignmentRow — covers day detail, timeline, and selected-day surfaces, which all delegate to it
dashboard/DashboardModels.kt Add tags: List<ShiftTagSummary> to NextShiftSummary
dashboard/DashboardDeriver.kt Map tags = shift.tags in toNextShift
dashboard/DashboardScreen.kt Render tag pills (reusing existing ShiftTypePill) on the next-shift hero

Reuses the existing colored-pill components and the same shift.tags source already used for coworker tags — no new tag model, no new networking, no DTO changes.

Test plan

  • ./gradlew :app:compileDebugKotlin — clean
  • ./gradlew :app:testDebugUnitTest — full unit suite passes (incl. ScheduleCalendarDeriverTest, ScheduleScreenPresentationTest, DashboardViewModelTest)
  • ./gradlew :app:lintDebug — BUILD SUCCESSFUL, no new lint errors
  • Manual: verify colored tag pills render on own shifts (schedule day view + dashboard next-shift) for tagged shifts, and nothing renders for untagged (regular) shifts; confirm coworker tags still render as before
## Summary Android counterpart to #330. Renders shift tags (`call`, `hot`, `preceptor`, …) at a glance on the staff member's **own** shift display so they can see what type of shift they're working. A shift with **no tags is a regular shift** (nothing rendered). Tags were already deserialized into `ShiftSummary.tags` from the schedule-detail endpoint and were already rendered on **coworker** rows ("Working Today"). This PR closes the remaining gap: the staff member's own shifts on the Schedule screen and the Dashboard next-shift hero. ## No backend dependency Unlike web (whose dashboard reads `/staff/:id/upcoming-assignments`), the Android dashboard and schedule both source shifts from the **schedule-detail** endpoint, which already carries `tags` on every shift. So this is a self-contained, Android-only change off `main` — it does **not** depend on #330's backend change. ## Changes | File | Change | |---|---| | `schedule/ScheduleCalendarModels.kt` | Add `tags: List<ShiftTagSummary>` to `ScheduleAssignmentDisplayRow` | | `schedule/ScheduleCalendarDeriver.kt` | Populate `tags = shift.tags` when building the own-shift row | | `schedule/ScheduleScreen.kt` | Render tag pills (reusing existing `RolePill`) on `AssignmentRow` — covers day detail, timeline, and selected-day surfaces, which all delegate to it | | `dashboard/DashboardModels.kt` | Add `tags: List<ShiftTagSummary>` to `NextShiftSummary` | | `dashboard/DashboardDeriver.kt` | Map `tags = shift.tags` in `toNextShift` | | `dashboard/DashboardScreen.kt` | Render tag pills (reusing existing `ShiftTypePill`) on the next-shift hero | Reuses the existing colored-pill components and the same `shift.tags` source already used for coworker tags — no new tag model, no new networking, no DTO changes. ## Test plan - [x] `./gradlew :app:compileDebugKotlin` — clean - [x] `./gradlew :app:testDebugUnitTest` — full unit suite passes (incl. `ScheduleCalendarDeriverTest`, `ScheduleScreenPresentationTest`, `DashboardViewModelTest`) - [x] `./gradlew :app:lintDebug` — BUILD SUCCESSFUL, no new lint errors - [x] Manual: verify colored tag pills render on own shifts (schedule day view + dashboard next-shift) for tagged shifts, and nothing renders for untagged (regular) shifts; confirm coworker tags still render as before
feat(android): surface shift tags on schedule and dashboard
All checks were successful
Code Scanning / Gitleaks secret scan (pull_request) Successful in 6s
Details
Code Scanning / Semgrep OSS source scan (pull_request) Successful in 42s
Details
Android / Android Validation (pull_request) Successful in 5m43s
Details
Security, Type Check & Runtime / Dependency Audit (pull_request) Successful in 9m47s
Details
Security, Type Check & Runtime / Migration Guardrails (pull_request) Successful in 9m44s
Details
Security, Type Check & Runtime / Type Check (pull_request) Successful in 10m24s
Details
Security, Type Check & Runtime / Backend Runtime Smoke (pull_request) Successful in 10m23s
Details
c8180d5416 
Mirror the web change: render shift tags (call, hot, preceptor, …) at a
glance so any staff member can see what type of shift they're working. No
tags means a regular shift.

Tags were already deserialized into ShiftSummary.tags from the
schedule-detail endpoint and rendered on coworker rows; this propagates
them to the staff member's own shift display:

- Add tags to ScheduleAssignmentDisplayRow and NextShiftSummary, populated
  from shift.tags in the schedule and dashboard derivers.
- Render tag pills (reusing RolePill / ShiftTypePill) on the schedule
  AssignmentRow (covers day detail + timeline + selected-day) and the
  dashboard next-shift hero.

No backend dependency: Android sources shifts from schedule-detail, which
already carries tags.
owlburtoe deleted branch android-shift-tags 2026-06-08 10:44:51 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:hermes
Ready for Hermes Agent to pick up or monitor

  
bug
Something is broken

  
chore
Maintenance or dependency work

  
dependency

   
feature
New behavior or capability

  
status:blocked
Blocked or needs clarification

  
status:in-progress
Work has started

  
status:needs-info
Needs more information before work can start

  
status:needs-review
Implemented and needs review

  
status:ready
Ready for implementation

No labels
agent:hermes
bug
chore
dependency
feature
status:blocked
status:in-progress
status:needs-info
status:needs-review
status:ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owlburtoe/Shiftd!332
No description provided.