owlburtoe/Shiftd
owlburtoe/Shiftd
0
0
Fork 0
Code Issues 1 Pull requests 4 Projects Releases 1 Packages 3 Wiki Activity Actions

fix(backend): serialize transaction queries for pg 9 #230

Merged
owlburtoe merged 1 commit from fix/issue-226-backend-test-isolation into main 2026-05-28 09:14:43 -04:00
Conversation 0 Commits 1 Files changed 3 +119 -20
owlburtoe commented 2026-05-28 07:50:05 -04:00
Owner
Copy link

Summary

  • Serialize Drizzle transaction queries in imported requirements replacement so pg no longer sees concurrent client.query() calls on one transaction client.
  • Serialize the transaction-backed getUnfilledSeats query bundle while preserving pooled Promise.all behavior outside transactions.
  • Add regression coverage for transaction safety and warning-free imported requirements replacement.

Test Plan

  • CI=true npx -y -p node@24 -p pnpm@11.1.1 bash -lc 'cd apps/backend && NODE_OPTIONS=--trace-deprecation DATABASE_URL=postgresql://shiftd:shiftd@127.0.0.1:5433/shiftd_test pnpm exec vitest run src/routes/__tests__/imported-schedule-requirements.test.ts --reporter=default'
  • CI=true npx -y -p node@24 -p pnpm@11.1.1 bash -lc 'node -v; pnpm -v; pnpm test:backend:db'

Closes #226

## Summary - Serialize Drizzle transaction queries in imported requirements replacement so pg no longer sees concurrent `client.query()` calls on one transaction client. - Serialize the transaction-backed `getUnfilledSeats` query bundle while preserving pooled `Promise.all` behavior outside transactions. - Add regression coverage for transaction safety and warning-free imported requirements replacement. ## Test Plan - `CI=true npx -y -p node@24 -p pnpm@11.1.1 bash -lc 'cd apps/backend && NODE_OPTIONS=--trace-deprecation DATABASE_URL=postgresql://shiftd:shiftd@127.0.0.1:5433/shiftd_test pnpm exec vitest run src/routes/__tests__/imported-schedule-requirements.test.ts --reporter=default'` - `CI=true npx -y -p node@24 -p pnpm@11.1.1 bash -lc 'node -v; pnpm -v; pnpm test:backend:db'` Closes #226
fix(backend): serialize transaction queries for pg 9
Some checks failed
Code Scanning / Gitleaks secret scan (pull_request) Successful in 6s
Details
Code Scanning / Semgrep OSS source scan (pull_request) Successful in 33s
Details
Release Artifacts / Validate release candidate (pull_request) Failing after 5m14s
Details
Release Artifacts / Build and push Docker release images (pull_request) Has been skipped
Details
Security, Type Check & Runtime / Type Check (pull_request) Failing after 5m3s
Details
Security, Type Check & Runtime / Backend Runtime Smoke (pull_request) Failing after 5m17s
Details
Security, Type Check & Runtime / Dependency Audit (pull_request) Successful in 9m41s
Details
Security, Type Check & Runtime / Migration Guardrails (pull_request) Successful in 9m35s
Details
E2E Tests / e2e (pull_request) Successful in 14m20s
Details
169e2ca47b
owlburtoe force-pushed fix/issue-226-backend-test-isolation from 169e2ca47b
Some checks failed
Code Scanning / Gitleaks secret scan (pull_request) Successful in 6s
Details
Code Scanning / Semgrep OSS source scan (pull_request) Successful in 33s
Details
Release Artifacts / Validate release candidate (pull_request) Failing after 5m14s
Details
Release Artifacts / Build and push Docker release images (pull_request) Has been skipped
Details
Security, Type Check & Runtime / Type Check (pull_request) Failing after 5m3s
Details
Security, Type Check & Runtime / Backend Runtime Smoke (pull_request) Failing after 5m17s
Details
Security, Type Check & Runtime / Dependency Audit (pull_request) Successful in 9m41s
Details
Security, Type Check & Runtime / Migration Guardrails (pull_request) Successful in 9m35s
Details
E2E Tests / e2e (pull_request) Successful in 14m20s
Details
to d5fde0ace3
All checks were successful
Code Scanning / Gitleaks secret scan (pull_request) Successful in 8s
Details
Code Scanning / Semgrep OSS source scan (pull_request) Successful in 37s
Details
Security, Type Check & Runtime / Dependency Audit (pull_request) Successful in 9m39s
Details
Release Artifacts / Validate release candidate (pull_request) Successful in 10m48s
Details
Release Artifacts / Build and push Docker release images (pull_request) Has been skipped
Details
Security, Type Check & Runtime / Migration Guardrails (pull_request) Successful in 9m36s
Details
Security, Type Check & Runtime / Backend Runtime Smoke (pull_request) Successful in 10m9s
Details
Security, Type Check & Runtime / Type Check (pull_request) Successful in 10m15s
Details
E2E Tests / e2e (pull_request) Successful in 14m43s
Details
2026-05-28 08:07:47 -04:00 Compare
owlburtoe changed title from fix(backend): serialize transaction queries for pg 9 to WIP: fix(backend): serialize transaction queries for pg 9 2026-05-28 08:40:02 -04:00
owlburtoe changed title from WIP: fix(backend): serialize transaction queries for pg 9 to fix(backend): serialize transaction queries for pg 9 2026-05-28 09:14:38 -04:00
owlburtoe deleted branch fix/issue-226-backend-test-isolation 2026-05-28 09:14:44 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:hermes
Ready for Hermes Agent to pick up or monitor

  
bug
Something is broken

  
chore
Maintenance or dependency work

  
dependency

   
feature
New behavior or capability

  
status:blocked
Blocked or needs clarification

  
status:in-progress
Work has started

  
status:needs-info
Needs more information before work can start

  
status:needs-review
Implemented and needs review

  
status:ready
Ready for implementation

No labels
agent:hermes
bug
chore
dependency
feature
status:blocked
status:in-progress
status:needs-info
status:needs-review
status:ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owlburtoe/Shiftd!230
No description provided.