owlburtoe/Shiftd
owlburtoe/Shiftd
0
0
Fork 0
Code Issues 1 Pull requests 4 Projects Releases 1 Packages 3 Wiki Activity Actions

feat: shift tags on staff upcoming-assignments (Slice 2 of calendar sync payload) #242

Merged
owlburtoe merged 2 commits from feat/calendar-sync-slice-2-assignment-tags into main 2026-05-28 16:15:30 -04:00
Conversation 0 Commits 2 Files changed 3 +111 -1
owlburtoe commented 2026-05-28 15:59:32 -04:00
Owner
Copy link

Slice 2 of the Calendar Sync Payload enrichment (spec: docs/superpowers/specs/2026-05-28-calendar-sync-payload-design.md, Section B). Adds shift tags to the staff upcoming-assignments payload so later slices (iOS EventKit sync, ICS feed) can render tag suffixes/notes. Runs parallel to merged Slice 1 (#225); no schema change.

Changes

  • Backend (repositories.ts): UpcomingAssignmentSummary gains a required tags: string[]. Tags are bulk-loaded for the returned shift IDs through shift_tags → tags (reusing getTagsForShifts), ordered lower(name) ASC, name ASC, id ASC. Shifts with no tags return []. The deterministic ordering was added to getTagsForShifts itself, so the schedule-grid consumer (getShiftsByScheduleId) also gets stable tag order.
  • OpenAPI: tags added to StaffUpcomingAssignment as a required string array (empty when none).
  • Test: new TDD case in staff-upcoming-assignments.test.ts covering case-insensitive ordering, the name ASC tie-break (Mango before mango), and [] for untagged shifts.

Test plan

  • TDD: test written → failed (tags undefined) → implemented → green
  • Full backend DB suite: 1470/1470 passing (132 files, 0 failures)
  • Tag-related files in isolation: 107/107 (lifecycle-tagging, tags, schedule-imports)
  • pnpm tsc --noEmit clean
  • OpenAPI parses; tags present + required
  • check:runtime-contracts, check:migration-ordering pass

No migration. No frontend change (additive field). Renderer + parity fixture land with Slices 3/4A per the spec slice table.

Slice 2 of the Calendar Sync Payload enrichment (spec: docs/superpowers/specs/2026-05-28-calendar-sync-payload-design.md, Section B). Adds shift tags to the staff upcoming-assignments payload so later slices (iOS EventKit sync, ICS feed) can render tag suffixes/notes. Runs parallel to merged Slice 1 (#225); no schema change. ## Changes - **Backend** (`repositories.ts`): `UpcomingAssignmentSummary` gains a required `tags: string[]`. Tags are bulk-loaded for the returned shift IDs through `shift_tags → tags` (reusing `getTagsForShifts`), ordered `lower(name) ASC, name ASC, id ASC`. Shifts with no tags return `[]`. The deterministic ordering was added to `getTagsForShifts` itself, so the schedule-grid consumer (`getShiftsByScheduleId`) also gets stable tag order. - **OpenAPI**: `tags` added to `StaffUpcomingAssignment` as a required string array (empty when none). - **Test**: new TDD case in `staff-upcoming-assignments.test.ts` covering case-insensitive ordering, the `name ASC` tie-break (`Mango` before `mango`), and `[]` for untagged shifts. ## Test plan - [x] TDD: test written → failed (`tags` undefined) → implemented → green - [x] Full backend DB suite: 1470/1470 passing (132 files, 0 failures) - [x] Tag-related files in isolation: 107/107 (lifecycle-tagging, tags, schedule-imports) - [x] `pnpm tsc --noEmit` clean - [x] OpenAPI parses; `tags` present + required - [x] `check:runtime-contracts`, `check:migration-ordering` pass No migration. No frontend change (additive field). Renderer + parity fixture land with Slices 3/4A per the spec slice table.
Add tags[] to UpcomingAssignmentSummary, bulk-loaded through shift_tags ->
tags and ordered lower(name) asc, name asc, id asc. Shifts without tags
return []. Implements Slice 2 of the calendar sync payload spec (Section B).
docs(openapi): add required tags[] to StaffUpcomingAssignment
All checks were successful
Code Scanning / Gitleaks secret scan (pull_request) Successful in 5s
Details
Code Scanning / Semgrep OSS source scan (pull_request) Successful in 32s
Details
Security, Type Check & Runtime / Dependency Audit (pull_request) Successful in 9m38s
Details
Security, Type Check & Runtime / Migration Guardrails (pull_request) Successful in 9m33s
Details
Security, Type Check & Runtime / Backend Runtime Smoke (pull_request) Successful in 10m14s
Details
Security, Type Check & Runtime / Type Check (pull_request) Successful in 10m15s
Details
Release Artifacts / Validate release candidate (pull_request) Successful in 10m48s
Details
Release Artifacts / Build and push Docker release images (pull_request) Has been skipped
Details
E2E Tests / e2e (pull_request) Successful in 14m34s
Details
80ae4714bb
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:hermes
Ready for Hermes Agent to pick up or monitor

  
bug
Something is broken

  
chore
Maintenance or dependency work

  
dependency

   
feature
New behavior or capability

  
status:blocked
Blocked or needs clarification

  
status:in-progress
Work has started

  
status:needs-info
Needs more information before work can start

  
status:needs-review
Implemented and needs review

  
status:ready
Ready for implementation

No labels
agent:hermes
bug
chore
dependency
feature
status:blocked
status:in-progress
status:needs-info
status:needs-review
status:ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owlburtoe/Shiftd!242
No description provided.