fix: delete-account timezone resilience test + timezone admin UI #289

Merged

owlburtoe merged 2 commits from worktree-fix+timezone-test-and-ui into main 2026-06-03 11:23:35 -04:00

Conversation 0 Commits 2 Files changed 4 +309 -76

owlburtoe commented 2026-06-03 10:43:35 -04:00

Owner

Copy link

Summary

• Backend test (apps/backend/src/lib/jobs/__tests__/delete-account.test.ts): Integration test for executeDeleteAccount that seeds a department with an invalid IANA timezone via direct DB write (bypassing the API validator), creates a future shift + assignment, and asserts the job completes without throwing (UTC fallback kicks in). Also adds a no-op/cancellation path test.
• Frontend UI (apps/frontend/src/components/settings/OrganizationSection.tsx): Adds a department timezone select to Settings → Organization. Uses Intl.supportedValuesOf('timeZone') grouped by region, wired into both handleLocationSave and handleDefaultsSave. Timezone is now editable by admin/department_admin and tracked in isLocationDirty. Backend already validates the IANA value (PUT /api/config/department → timezoneSchema).

Closes two open bugs from TODO.md:

• delete-account job-path resilience test for invalid dept timezone
• Department timezone admin UI in Settings

Test plan

• pnpm test:backend:db -- --testPathPattern=delete-account — 2 new tests pass
• pnpm --filter icu-schedule-app check-types — no TS errors
• Settings → Organization as admin: timezone select appears, changing it and saving sends the value to PUT /api/config/department, success toast fires
• Settings → Organization as non-admin: timezone select is disabled
• Changing timezone to an invalid value (direct API) returns 400

## Summary - **Backend test** (`apps/backend/src/lib/jobs/__tests__/delete-account.test.ts`): Integration test for `executeDeleteAccount` that seeds a department with an invalid IANA timezone via direct DB write (bypassing the API validator), creates a future shift + assignment, and asserts the job completes without throwing (UTC fallback kicks in). Also adds a no-op/cancellation path test. - **Frontend UI** (`apps/frontend/src/components/settings/OrganizationSection.tsx`): Adds a department timezone select to Settings → Organization. Uses `Intl.supportedValuesOf('timeZone')` grouped by region, wired into both `handleLocationSave` and `handleDefaultsSave`. Timezone is now editable by `admin`/`department_admin` and tracked in `isLocationDirty`. Backend already validates the IANA value (`PUT /api/config/department` → `timezoneSchema`). Closes two open bugs from `TODO.md`: - `delete-account` job-path resilience test for invalid dept timezone - Department timezone admin UI in Settings ## Test plan - [ ] `pnpm test:backend:db -- --testPathPattern=delete-account` — 2 new tests pass - [ ] `pnpm --filter icu-schedule-app check-types` — no TS errors - [ ] Settings → Organization as admin: timezone select appears, changing it and saving sends the value to `PUT /api/config/department`, success toast fires - [ ] Settings → Organization as non-admin: timezone select is disabled - [ ] Changing timezone to an invalid value (direct API) returns 400

owlburtoe added 1 commit 2026-06-03 10:43:35 -04:00

fix: add delete-account timezone resilience test and timezone admin UI ... 42dc4a9580

- Add integration test for executeDeleteAccount that seeds a dept with
  an invalid IANA timezone via direct DB write (bypassing API validator),
  creates a future shift+assignment, and asserts the job completes without
  throwing. Also adds a no-op test for the cancellation path.
- Add department timezone select to OrganizationSection (Settings → Dept)
  using Intl.supportedValuesOf grouped by region. Timezone is now editable
  by admins and wired into both save handlers; isLocationDirty tracks changes.

Closes two open bugs from TODO:
- delete-account job-path resilience test for invalid dept timezone
- Department timezone admin UI in Settings

owlburtoe added the

feature

label 2026-06-03 10:47:33 -04:00

owlburtoe added 1 commit 2026-06-03 10:56:52 -04:00

refactor(settings): fix set-state-in-effect lint warning in OrganizationSection ... f22aa14deb

Split OrganizationSection into a loading shell and OrganizationForm inner
component. The inner component receives config as a prop and initializes
state via the useState lazy initializer, eliminating the useEffect setState
sync that triggered react-hooks/set-state-in-effect.

Also consolidates the 7 individual form state variables into a single
FormState object with a configToForm helper.

owlburtoe merged commit ec01e45f05 into main 2026-06-03 11:23:35 -04:00

owlburtoe deleted branch worktree-fix+timezone-test-and-ui 2026-06-03 11:23:35 -04:00

owlburtoe referenced this pull request from a commit 2026-06-03 11:23:36 -04:00

Merge pull request 'fix: delete-account timezone resilience test + timezone admin UI' (#289) from worktree-fix+timezone-test-and-ui into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent:hermes

Ready for Hermes Agent to pick up or monitor

  

bug

Something is broken

  

chore

Maintenance or dependency work

  

dependency

  

feature

New behavior or capability

  

status:blocked

Blocked or needs clarification

  

status:in-progress

Work has started

  

status:needs-info

Needs more information before work can start

  

status:needs-review

Implemented and needs review

  

status:ready

Ready for implementation

No labels

agent:hermes

bug

chore

dependency

feature

status:blocked

status:in-progress

status:needs-info

status:needs-review

status:ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

owlburtoe/Shiftd!289

No description provided.