fix: enforce lifecycle gate on staff shift self-withdrawal #291

Merged

owlburtoe merged 1 commit from fix/shift-withdrawal-lifecycle-gate into main 2026-06-03 20:47:35 -04:00

Conversation 0 Commits 1 Files changed 13 +275 -13

owlburtoe commented 2026-06-03 18:48:38 -04:00

Owner

Copy link

Summary

• Staff self-withdrawal from the Shift Signup page is now blocked once the schedule's signup window closes. Allowed phases: open, open_self_signup, open_supplemental, open_call, and published with an active supplemental window. Scheduler/admin unassigns are unaffected.
• isStaffWithdrawable() helper added to backend schedule-lifecycle.ts; lifecycle check added to the unassign handler before the engine is invoked.
• scheduleStatus + canWithdraw threaded through EnrichedShift → MySignedUpEntry via useMySchedule / useShiftSignupCalendar / buildShiftSignupCalendarView. SignedUpShiftAccordionItem renders a "signup window has closed" message instead of the Withdraw button when canWithdraw is false.
• Published schedules with an active supplemental window now correctly surface in the signed-up list (previously hidden by the blanket isPublished filter) with canWithdraw: true.

Test plan

• Run backend integration tests with Docker: pnpm test:backend:db — 8 new cases covering all lifecycle states, published+supplemental active/expired, scheduler bypass
• Run frontend unit tests: pnpm vitest run src/lib/shiftSignup/ — 3 new cases covering visibility and canWithdraw computation
• Smoke: open a schedule in open_self_signup, sign up for a shift, verify Withdraw button shows
• Smoke: advance schedule to admin_adjustment, revisit Shift Signup → verify button replaced by "signup window has closed" message
• Smoke: open supplemental window on a published schedule, sign up, verify Withdraw available; let window expire, verify it disappears

## Summary - Staff self-withdrawal from the Shift Signup page is now blocked once the schedule's signup window closes. Allowed phases: `open`, `open_self_signup`, `open_supplemental`, `open_call`, and `published` with an active supplemental window. Scheduler/admin unassigns are unaffected. - `isStaffWithdrawable()` helper added to backend `schedule-lifecycle.ts`; lifecycle check added to the `unassign` handler before the engine is invoked. - `scheduleStatus` + `canWithdraw` threaded through `EnrichedShift` → `MySignedUpEntry` via `useMySchedule` / `useShiftSignupCalendar` / `buildShiftSignupCalendarView`. `SignedUpShiftAccordionItem` renders a "signup window has closed" message instead of the Withdraw button when `canWithdraw` is false. - Published schedules with an active supplemental window now correctly surface in the signed-up list (previously hidden by the blanket `isPublished` filter) with `canWithdraw: true`. ## Test plan - [ ] Run backend integration tests with Docker: `pnpm test:backend:db` — 8 new cases covering all lifecycle states, published+supplemental active/expired, scheduler bypass - [ ] Run frontend unit tests: `pnpm vitest run src/lib/shiftSignup/` — 3 new cases covering visibility and `canWithdraw` computation - [ ] Smoke: open a schedule in `open_self_signup`, sign up for a shift, verify Withdraw button shows - [ ] Smoke: advance schedule to `admin_adjustment`, revisit Shift Signup → verify button replaced by "signup window has closed" message - [ ] Smoke: open supplemental window on a published schedule, sign up, verify Withdraw available; let window expire, verify it disappears

owlburtoe added 1 commit 2026-06-03 18:48:38 -04:00

fix: enforce lifecycle gate on staff shift self-withdrawal ... a0d04d2229

Staff can now only withdraw from shifts they signed up for while the
relevant signup window is still open. Once the schedule transitions out
of the window phase (e.g. to admin_adjustment), the unassign endpoint
returns 409 for staff actors and the Shift Signup UI replaces the
Withdraw button with an informational message.

Allowed withdrawal states: open, open_self_signup, open_supplemental,
open_call, and published schedules with an active supplemental window.
Scheduler/admin unassigns bypass the lifecycle check entirely.

Backend: isStaffWithdrawable() helper in schedule-lifecycle.ts;
lifecycle check added to the unassign handler in scheduleController.ts.

Frontend: scheduleStatus + canWithdraw threaded through EnrichedShift →
MySignedUpEntry via useMySchedule/useShiftSignupCalendar/
buildShiftSignupCalendarView. Published-supplemental assignments are
now included in the signed-up list (previously hidden by the
isPublished filter) and correctly show canWithdraw=true while the
window is open. SignedUpShiftAccordionItem renders the message when
canWithdraw is false.

Tests: 8 new backend integration tests (blocks in admin_adjustment,
allows in open_self_signup/open_supplemental/open_call, published+
active/expired supplemental, scheduler unblocked); 3 new frontend
unit tests (published shift visibility with active supplemental,
canWithdraw computation across all lifecycle states).

owlburtoe referenced this pull request 2026-06-03 20:03:40 -04:00

fix(deps): bump react-router to 6.30.4 (GHSA-2j2x-hqr9-3h42) #292

owlburtoe force-pushed fix/shift-withdrawal-lifecycle-gate from a0d04d2229 to 6581848a55 2026-06-03 20:28:01 -04:00 Compare

owlburtoe merged commit ae6a729e08 into main 2026-06-03 20:47:35 -04:00

owlburtoe deleted branch fix/shift-withdrawal-lifecycle-gate 2026-06-03 20:47:36 -04:00

owlburtoe referenced this pull request from a commit 2026-06-03 20:47:37 -04:00

Merge pull request 'fix: enforce lifecycle gate on staff shift self-withdrawal' (#291) from fix/shift-withdrawal-lifecycle-gate into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent:hermes

Ready for Hermes Agent to pick up or monitor

  

bug

Something is broken

  

chore

Maintenance or dependency work

  

dependency

  

feature

New behavior or capability

  

status:blocked

Blocked or needs clarification

  

status:in-progress

Work has started

  

status:needs-info

Needs more information before work can start

  

status:needs-review

Implemented and needs review

  

status:ready

Ready for implementation

No labels

agent:hermes

bug

chore

dependency

feature

status:blocked

status:in-progress

status:needs-info

status:needs-review

status:ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

owlburtoe/Shiftd!291

No description provided.