owlburtoe/pi-claudify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: carry accent-aliased theme keys (mdCode, mdListBullet) in the accent override #47

Merged
owlburtoe merged 1 commit from clfy-accent-aliases into master 2026-07-16 19:31:04 -04:00
Conversation 0 Commits 1 Files changed 3 +40 -4
owlburtoe commented 2026-07-16 19:29:07 -04:00
Owner
Copy link

Live smoke finding: file listings in the transcript stayed teal (38;2;138;190;183) after the accent fix — pi's dark theme resolves mdCode and mdListBullet from the same accent var, and the override only rewrote the accent key.

The override now records, per theme instance, every fgColors key whose loaded value aliased the accent, and rewrites/restores them together with it. Non-aliased keys are untouched; accentColor: "theme" restores all of them exactly. Works for custom themes too — aliasing is detected by value at load, not by a hardcoded key list.

Honest caveat (in the doc): Claude Code's exact inline-code color is uncaptured — scratch CC sessions kept stalling — so this treats accent-aliased surfaces as accent-colored (the theme's own declared intent, visually consistent with CC's blue-family inline code). A future capture may refine mdCode to its own CC value.

  • Alias follow + exact restore + non-aliased untouched covered in scripts/test-claudify-hub.ts; 15/15 suites; tsc strict clean.
  • Live retest in the smoke session.
Live smoke finding: file listings in the transcript stayed teal (`38;2;138;190;183`) after the accent fix — pi's dark theme resolves `mdCode` and `mdListBullet` from the same `accent` var, and the override only rewrote the `accent` key. The override now records, per theme instance, every `fgColors` key whose loaded value aliased the accent, and rewrites/restores them together with it. Non-aliased keys are untouched; `accentColor: "theme"` restores all of them exactly. Works for custom themes too — aliasing is detected by value at load, not by a hardcoded key list. Honest caveat (in the doc): Claude Code's exact inline-code color is uncaptured — scratch CC sessions kept stalling — so this treats accent-aliased surfaces as accent-colored (the theme's own declared intent, visually consistent with CC's blue-family inline code). A future capture may refine `mdCode` to its own CC value. - [x] Alias follow + exact restore + non-aliased untouched covered in `scripts/test-claudify-hub.ts`; 15/15 suites; tsc strict clean. - [ ] Live retest in the smoke session.
fix: carry accent-aliased theme keys (mdCode, mdListBullet) in the accent override
All checks were successful
Plane Sync / Close referenced Plane work items (pull_request) Successful in 2s
Details
57467a8542 
pi's dark theme resolves mdCode/mdListBullet from the accent var, so inline
code and bullets in the transcript stayed teal after the accent override
(live smoke finding: file listings rendered 38;2;138;190;183). The override
now records every fgColors key whose loaded value aliased the accent and
rewrites/restores them alongside it. CC's exact inline-code value remains
uncaptured (noted in the doc); accent-aliased-follows-accent is the theme's
declared intent.
owlburtoe merged commit 3f0c5e61d0 into master 2026-07-16 19:31:04 -04:00
owlburtoe deleted branch clfy-accent-aliases 2026-07-16 19:31:05 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
owlburtoe/pi-claudify!47
No description provided.